Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: remove tips #17787

Merged
merged 10 commits into from
Sep 20, 2023
Merged

refactor!: remove tips #17787

merged 10 commits into from
Sep 20, 2023

Conversation

tac0turtle
Copy link
Member

Description

This pr removes tips as it has not undergone audit and will be brought back when an audit can be scheduled

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@tac0turtle tac0turtle added the backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release label Sep 18, 2023
@tac0turtle tac0turtle marked this pull request as ready for review September 19, 2023 09:24
@tac0turtle tac0turtle requested a review from a team as a code owner September 19, 2023 09:24
julienrbrt
julienrbrt reviewed Sep 20, 2023
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly lgtm. Just some thoughts for not being proto breaking and being able to keep tagging api from main.

proto/cosmos/tx/v1beta1/tx.proto Show resolved Hide resolved
proto/cosmos/tx/v1beta1/tx.proto Show resolved Hide resolved
julienrbrt
julienrbrt approved these changes Sep 20, 2023
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

testinginprod
testinginprod approved these changes Sep 20, 2023
View reviewed changes
Copy link
Contributor

@testinginprod testinginprod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tac0turtle tac0turtle added this pull request to the merge queue Sep 20, 2023
Merged via the queue into main with commit 6715b5a Sep 20, 2023
51 of 52 checks passed
@tac0turtle tac0turtle deleted the marko/remove_tips branch September 20, 2023 12:04
mergify bot pushed a commit that referenced this pull request Sep 20, 2023
@tac0turtle @mergify
refactor!: remove tips (#17787)
a206729 
(cherry picked from commit 6715b5a)

# Conflicts:
#	CHANGELOG.md
#	client/tx/factory.go
#	client/tx/tx.go
#	docs/docs/develop/advanced/14-tips.md
#	x/auth/tx/aux_test.go
#	x/tx/decode/fuzz_test.go
#	x/tx/signing/aminojson/fuzz_test.go
@mergify mergify bot mentioned this pull request Sep 20, 2023
Merged
julienrbrt pushed a commit that referenced this pull request Sep 20, 2023
@tac0turtle @julienrbrt
refactor!: remove tips (#17787)
e982c91
tac0turtle added a commit that referenced this pull request Sep 21, 2023
@mergify @tac0turtle @julienrbrt
refactor!: remove tips (backport #17787) (#17819)
deea20c 
Co-authored-by: Marko <marbar3778@yahoo.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
@coderabbitai coderabbitai bot mentioned this pull request Apr 22, 2024
Merged
12 tasks
@faddat faddat mentioned this pull request Nov 8, 2024
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@testinginprod testinginprod testinginprod approved these changes

@julienrbrt julienrbrt julienrbrt approved these changes

@kocubinski kocubinski Awaiting requested review from kocubinski kocubinski is a code owner

Assignees

@julienrbrt julienrbrt

@testinginprod testinginprod

Labels
backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release C:CLI C:x/auth C:x/authz C:x/feegrant C:x/tx
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tac0turtle @julienrbrt @testinginprod